Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUD-838 - [PSMDB Operator] Support health and metrics endpoints #173

Merged
merged 6 commits into from
Jan 31, 2024
Merged

CLOUD-838 - [PSMDB Operator] Support health and metrics endpoints #173

merged 6 commits into from
Jan 31, 2024

Conversation

dalbani
Copy link
Contributor

@dalbani dalbani commented Sep 26, 2022

Or is there a reason I'm not aware of why health and metrics endpoints are not used?

@dalbani
Fix container port for metrics
8fa11c2
@dalbani
Add port for health
d64f24e 
To be used for liveness and readiness probes.
@spron-in
Copy link
Collaborator

Hey @dalbani - sorry for a hold up. Let us quickly check!

@tplavcic
Copy link
Member

tplavcic commented Nov 3, 2022

@dalbani Maybe I'm missing something, but is this specific to helm chart only?
It seems to me this maybe should be changed first here: https://github.com/percona/percona-server-mongodb-operator/blob/main/deploy/operator.yaml
and then if merged it should be changed in the helm chart as well.

@dalbani
Copy link
Contributor Author

dalbani commented Nov 3, 2022

@tplavcic
I don't know what this https://github.com/percona/percona-server-mongodb-operator/blob/main/deploy/operator.yaml is supposed to be used for. I mean, the other files in the same folder seem to be related to tests??
Anyway, the source code of the operator is pretty clear on which ports are used for health and metrics: https://github.com/percona/percona-server-mongodb-operator/blob/main/cmd/manager/main.go#L58.

@tplavcic tplavcic requested review from egegunes and removed request for cap1984 September 8, 2023 11:48
@egegunes egegunes mentioned this pull request Jan 19, 2024
Closed
@tplavcic tplavcic changed the title [PSMDB Operator] Support health and metrics endpoints CLOUD-838 - [PSMDB Operator] Support health and metrics endpoints Jan 31, 2024
@tplavcic
Copy link
Member

Thank you for the contribution!

@tplavcic tplavcic merged commit c8a76e1 into percona:main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tplavcic tplavcic tplavcic approved these changes

@ptankov ptankov ptankov approved these changes

@egegunes egegunes Awaiting requested review from egegunes

Assignees
No one assigned
Labels
community psmdb testing-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dalbani @spron-in @tplavcic @ptankov @egegunes